Refactor the pre-commit model a bit.

Review Request #6121 — Created July 21, 2014 and submitted

Information

Review Board
master
4e44d81...

Reviewers

I'm working on making it so "Update Diff" behaves/looks similar to the
pre-commit section of the "New Review Request" page. This change is a
preperatory step: separating the review request creation from the diff
creation. After this change, RB.PreCommitModel should be usable when a review
request already exists, by setting the reviewRequest attribute.

Verified that pre-commit review request creation still worked properly with
both single and parent diffs.

reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/newReviewRequest/models/preCommitModel.js
    
    
    
    Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/newReviewRequest/models/preCommitModel.js
    
    
  2. 
      
chipx86
  1. Ship It!

  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to master (9ccb537)