Summary

Fix args to error callback when publishing a draft review request.

Review Request #6108 — Created July 15, 2014 and submitted July 16, 2014, 3:55 p.m.

Information

Owner

mcote

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

smacleod

Description

It appears, from my testing and from the Firefox debugger, that the error callback in DraftReviewResource.publish() has the same args as .save(), that is, (model, xhr, ...).  I believe an earlier change to just (xhr) for the publish() error callback was in error.

Testing Done

Manually generated a PublishError via an extension. Confirmed that the message did not appear in the alert dialog without the fix, and that it did with the fix.

Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/models/reviewRequestEditorModel.js



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/models/reviewRequestEditorModel.js

Description:: ~
Fix args to error callback when publishing a draft review request.
~
It appears, from my testing and from the Firefox debugger, that the error callback in
+ DraftReviewResource.publish() has the same args as .save(), that is, (model, xhr, ...). I believe an earlier change to just (xhr) for the publish() error callback was in error.

Change Summary:: Fix formatting in Description.
Description:: ~
It appears, from my testing and from the Firefox debugger, that the error callback in
~
It appears, from my testing and from the Firefox debugger, that the error callback in DraftReviewResource.publish() has the same args as .save(), that is, (model, xhr, ...). I believe an earlier change to just (xhr) for the publish() error callback was in error.
- DraftReviewResource.publish() has the same args as .save(), that is, (model, xhr, ...). I believe an earlier change to just (xhr) for the publish() error callback was in error.

Ship it!

This looks good for errors coming from the server, but validation errors now break (which is what the earlier commit was fixing). I'm going to change it so that validation errors call the error callback with the same signature as errors from the server.

Status:: Completed
Change Summary:: Pushed to release-2.0.x (dc79016)

~		Fix args to error callback when publishing a draft review request.
	~	It appears, from my testing and from the Firefox debugger, that the error callback in
	+	DraftReviewResource.publish() has the same args as .save(), that is, (model, xhr, ...). I believe an earlier change to just (xhr) for the publish() error callback was in error.