• 
      

    Fix visual issues with saving fields during publish.

    Review Request #6100 — Created July 11, 2014 and submitted

    Information

    Review Board
    release-2.0.x
    8a6d583...

    Reviewers

    When publishing a draft review request, we go through and save all open
    inlineEditors. This was using the "save" method instead of "submit", which
    caused a regression in multi-line fields that use CodeMirror. The result of
    this is that the fields would disappear entirely. Switching to "submit" makes
    it show the rendered version properly.

    Made some changes to "description" and "testing done", and then tried to
    publish my draft. Saw that the fields didn't disappear.

    reviewbot
    1. Tool: PEP8 Style Checker
      Ignored Files:
          reviewboard/static/rb/js/views/reviewRequestEditorView.js
      
      
      
      Tool: Pyflakes
      Ignored Files:
          reviewboard/static/rb/js/views/reviewRequestEditorView.js
      
      
    2. 
        
    chipx86
    1. Ship It!

    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (1cea509)