• 
      

    Print out "your review request still exists" when there are field errors.

    Review Request #6098 — Created July 11, 2014 and submitted

    Information

    RBTools
    release-0.6.x
    d8de4cc...

    Reviewers

    When posting a change, if the diff has a parse error, we printed out a message
    that a review request was created, including the URL to it. In the case where
    updating the draft fails (for example, when assigning reviewers based on command-line
    arguments), we weren't showing a similar error. This change fixes it so that
    the user gets the full error.

    Tried to post a change with an invalid group listed in --target-groups. Saw an
    error that included the new output.

    Description From Last Updated

    Why not just build this as one list, passed to CommandError?

    chipx86chipx86
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          rbtools/commands/post.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          rbtools/commands/post.py
      
      
    2. 
        
    BC
    1. Ship It!

    2. 
        
    chipx86
    1. 
        
    2. rbtools/commands/post.py (Diff revision 1)
       
       
       
       
       
       
      Show all issues

      Why not just build this as one list, passed to CommandError?

    3. 
        
    david
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          rbtools/commands/post.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          rbtools/commands/post.py
      
      
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-0.6.x (4ad88b1)