Summary

Add support for 'rbt patch -c' for Mercurial repositories

Review Request #6090 — Created July 9, 2014 and submitted July 10, 2014, 5:40 p.m.

Information

Owner

bcran

Repository

RBTools

Branch

release-0.6.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

Implement create_commit() in mercurial.py to support committing using information from the review request.

Testing Done

Posted a patch to Review Board, popped it off the queue, ran 'rbt patch -c <review_id>' and verified that the changeset was correctly committed.

Issues

Description	From	Last Updated
Can you add a docstring?	david	July 10, 2014, 5:33 p.m.
Since files is an empty list, all of this can be replaced with just execute(hg_command + files)	david	July 10, 2014, 5:33 p.m.
In other commands we use "Git/Mercurial only"	david	July 10, 2014, 5:33 p.m.

Tool: PEP8 Style Checker
Processed Files:
    rbtools/commands/patch.py
    rbtools/clients/mercurial.py



Tool: Pyflakes
Processed Files:
    rbtools/commands/patch.py
    rbtools/clients/mercurial.py

Testing Done:: ~
Posted a patch to Review Board, popped it off the queue, ran 'rbt patch -c <review_id>' and verfied that the changeset was correctly committed.
~
Posted a patch to Review Board, popped it off the queue, ran 'rbt patch -c <review_id>' and verified that the changeset was correctly committed.

rbtools/clients/mercurial.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can you add a docstring?
```

rbtools/clients/mercurial.py (Diff revision 1)

The issue has been resolved. Show all issues

Since files is an empty list, all of this can be replaced with just execute(hg_command + files)

rbtools/commands/patch.py (Diff revision 1)
The issue has been resolved. Show all issues
```
In other commands we use "Git/Mercurial only"
```

Change Summary:

Changed help text to 'Git/Mercurial', added docstrings to create_commit() in git.py and mercurial.py, and simplified hg_command code.

Diff:

Revision 2 (+18 -1)

Show changes

	rbtools/clients/git.py
	rbtools/clients/mercurial.py
	rbtools/commands/patch.py

Tool: Pyflakes
Processed Files:
    rbtools/commands/patch.py
    rbtools/clients/mercurial.py
    rbtools/clients/git.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/commands/patch.py
    rbtools/clients/mercurial.py
    rbtools/clients/git.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-0.6.x (5820d97)