Fix unicode errors with utf-8 files that have svn:keywords set.
Review Request #6052 — Created July 3, 2014 and submitted
In the case where a file in SVN had both unicode characters in it and
svn:keywords, trying to fetch the files would cause UnicodeDecodeErrors when
processing the keywords. I've fixed things up to do all the regex work in bytes
mode.
Ran unit tests. Before the changes to svn/base.py, the new test failed with the
same error as in the bug reports we've received about this. After, the test
runs fine.
Tool: Pyflakes Processed Files: reviewboard/scmtools/tests.py reviewboard/scmtools/svn/base.py Ignored Files: reviewboard/scmtools/testdata/svn_repo/db/revs/8 reviewboard/scmtools/testdata/svn_repo/db/revs/9 reviewboard/scmtools/testdata/svn_repo/db/current reviewboard/scmtools/testdata/svn_repo/db/revprops/9 reviewboard/scmtools/testdata/svn_repo/db/revprops/8 Tool: PEP8 Style Checker Processed Files: reviewboard/scmtools/tests.py reviewboard/scmtools/svn/base.py Ignored Files: reviewboard/scmtools/testdata/svn_repo/db/revs/8 reviewboard/scmtools/testdata/svn_repo/db/revs/9 reviewboard/scmtools/testdata/svn_repo/db/current reviewboard/scmtools/testdata/svn_repo/db/revprops/9 reviewboard/scmtools/testdata/svn_repo/db/revprops/8