Provide better protection for creating from changenums on Local Sites.

Review Request #6027 — Created June 25, 2014 and submitted — Latest diff uploaded

Information

Review Board
release-1.7.x
4ad7f9f...

Reviewers

We saw an issue where a review request on a Local Site was getting
created without a local_id. This seems likely to be due to an exception
when updating from a change number. I could not reproduce it locally,
but it makes sense.

This adds some bullet-proofing to that, falling back to not updating the
review request. It also doesn't attempt to update until after the review
request has been assigned a local_id (if on a Local Site).

Reproduced the original bug locally. After this fix, I could not reproduce
it.

I forced an exception to raise and then tried posting. I saw the log
message, but the review request was created, with a local ID.