Implement the rest of the webhook events.

Review Request #6019 — Created June 23, 2014 and submitted

Information

Review Board
master
1bfa1e5...

Reviewers

This change includes webhook implementations for the following events: * review_request_closed * review_request_reopened * review_published * reply_published

The review and reply events include both the "review" data as well as all of
the comments. While this data is already available through the API, it's
inconvenient to have to do a bunch of extra fetches, so it's included here.

Did each of the operations and saw the results on requestb.in

reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/notifications/webhooks.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/notifications/webhooks.py
    
    
  2. 
      
david
chipx86
  1. One thing I didn't think of before. I know we encode the event in the X-ReviewBoard-Event header, but can we also provide it standard in the payload? It'll be a bit easier both to work with and debug.

  2. reviewboard/notifications/webhooks.py (Diff revision 1)
     
     
     

    Do we need review_request_id if they can access review_request.id? I guess this applies to other payloads as well.

  3. 
      
david
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/notifications/webhooks.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/notifications/webhooks.py
    
    
  2. 
      
chipx86
  1. Ship It!

  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to master (7778a86)