Implement the rest of the webhook events.
Review Request #6019 — Created June 23, 2014 and submitted
This change includes webhook implementations for the following events:
*review_request_closed
*review_request_reopened
*review_published
*reply_publishedThe review and reply events include both the "review" data as well as all of
the comments. While this data is already available through the API, it's
inconvenient to have to do a bunch of extra fetches, so it's included here.
Did each of the operations and saw the results on requestb.in
-
One thing I didn't think of before. I know we encode the event in the X-ReviewBoard-Event header, but can we also provide it standard in the payload? It'll be a bit easier both to work with and debug.
-
Do we need
review_request_idif they can accessreview_request.id? I guess this applies to other payloads as well.
- Change Summary:
-
Include the event name in the payload but not the review request ID.
- Commit:
-
30f7696aebdb88b418cb011c2d27290829dffe4a1bfa1e537bfa337695e76f9ee19c8ff713e81943
- Diff:
-
Revision 2 (+98 -5)
Tool: PEP8 Style Checker Processed Files: reviewboard/notifications/webhooks.py Tool: Pyflakes Processed Files: reviewboard/notifications/webhooks.py