chipx86 got a fish trophy!

Summary

[2.0] Allow Review UIs to decide whether they're usable on a case-by-case basis.

Review Request #6006 — Created June 17, 2014 and submitted June 17, 2014, 6:04 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

c64ad36...

Reviewers

Groups

reviewboard

People

Description

ReviewUI subclaseses can now define a is_enabled_for() function, which
returns whether it can be enabled for the given user, review request,
and/or file attachment. This allows, for instance, limiting a review UI
based on extra_data on an object, or based on the given user or
Local Site, or anything else.

Testing Done

Tested this with a file attachment returning True, and then returning False.

Implemented a custom version and tested by file attachment name.

Issues

Description	From	Last Updated
list comprehension redefines 'file_attachment' from line 580	reviewbot	June 17, 2014, 4:46 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/ui/base.py
    reviewboard/reviews/templatetags/reviewtags.py

Ignored Files:
    reviewboard/templates/reviews/parts/file_attachment_thumbnail.html



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/ui/base.py
    reviewboard/reviews/templatetags/reviewtags.py

Ignored Files:
    reviewboard/templates/reviews/parts/file_attachment_thumbnail.html

reviewboard/reviews/views.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 list comprehension redefines 'file_attachment' from line 580
```

Testing Done:: Tested this with a file attachment returning True, and then returning False.

~
Implemented a custom verison and tested by file attachment name.
~
Implemented a custom version and tested by file attachment name.

Summary:: Allow Review UIs to decide whether they're usable on a case-by-case basis.
[2.0] Allow Review UIs to decide whether they're usable on a case-by-case basis.

```
Same questions as on the 1.7 version.
```

Status:: Completed

		Tested this with a file attachment returning True, and then returning False.

~		Implemented a custom verison and tested by file attachment name.
	~	Implemented a custom version and tested by file attachment name.