Summary

Avoid deleting previous PYTHONPATH

Review Request #6001 — Created June 16, 2014 and submitted June 17, 2014, 12:10 a.m.

Information

Owner

carloscorrales

Repository

Djblets

Branch

Bugs

Depends On

Blocks

6165

Reviewers

Groups

djblets

People

Description

With the previous putenv command, if an user had already set the PYTHONPATH environment variable, its value was deleted and substituted by os.getcwd(), which may prevent the installation if the dependencies are installed in a different path. Now, it appends this value to the previous value set in the sys.path, so the user configuration is kept.

Testing Done

Issues

Description	From	Last Updated
Col: 24 E211 whitespace before '('	reviewbot	June 16, 2014, 1:58 a.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    setup.py
  Ignored Files:

setup.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 24
 E211 whitespace before '('
```

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    setup.py
  Ignored Files:

Diff:

Revision 2 (+1 -1)

Show changes

setup.py

Diff:

Revision 3 (+1 -1)

Show changes

setup.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    setup.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    setup.py
  Ignored Files:

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-0.8.x (c79ff44)

I wish I had seen this sooner. This change completely reverts the fix from https://reviews.reviewboard.org/r/5300/

The reason that it was done as a os.putenv() instead of as sys.path.append() is because the subprocess doesn't inherit this value. By changing this, you reintroduced the original issue.

The correct fix here would be to append to the PYTHONPATH environment variable instead of replacing it. I'll submit a new patch to fix this.

setup.py (Diff revision 1)