• 
      
    Fish Trophy

    chipx86 got a fish trophy!

    Fish Trophy

    Improve style customization of the configforms templates.

    Review Request #5995 — Created June 14, 2014 and submitted

    Information

    Djblets
    release-0.8.x
    727e0a9...

    Reviewers

    This enhances the configforms in a few ways to allow for more flexible
    styling.

    First, the boxes now make use of a box-foot class, which is used on
    RBCommons. This extensions our box style convention to have a "head",
    "main", and "foot", allowing for a separation of CSS rules for the main
    part of a box and the footer.

    It's also now possible to specify the base template name through a
    base_template_name attribute on the ConfigPagesView.

    Field rows will now contain a checkbox-row class if it's a checkbox,
    radio button, or a multi-select of checkboxes.

    Finally, there was a typo where clas= was used instead of class=,
    which has been fixed.

    Made use of these fixes in another change.

    Saw that things still looked correct on Review Board.

    reviewbot
    1. This is a review from Review Bot.
        Tool: PEP8 Style Checker
        Processed Files:
          djblets/configforms/views.py
          djblets/util/templatetags/djblets_forms.py
        Ignored Files:
          djblets/configforms/templates/configforms/config_page.html
          djblets/configforms/templates/configforms/config.html
          djblets/configforms/templates/configforms/config_page_form.html
      
      
    2. 
        
    reviewbot
    1. This is a review from Review Bot.
        Tool: Pyflakes
        Processed Files:
          djblets/configforms/views.py
          djblets/util/templatetags/djblets_forms.py
        Ignored Files:
          djblets/configforms/templates/configforms/config_page.html
          djblets/configforms/templates/configforms/config.html
          djblets/configforms/templates/configforms/config_page_form.html
      
      
    2. 
        
    david
    1. Ship It!

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (8f01310)
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-0.8.x (8f01310)