• 
      

    Fix resource collection previous index

    Review Request #5989 — Created June 13, 2014 and submitted

    Information

    Djblets
    master
    ce5270b...

    Reviewers

    Fix resource collection previous index

    After upgrading to ReviewBoard 2.0, we were getting errors from tools that query user lists. Making this change fixed it.

    Old error (btw, happens the same on our prototype server which uses python 2.7):

    Traceback (most recent call last):
    ...

    File "/usr/lib/python2.6/site-packages/Djblets-0.8.4-py2.6.egg/djblets/webapi/responses.py", line 211, in get_prev_index
    return max(self.start - self.max_results)

    TypeError: 'int' object is not iterable

    reviewbot
    1. This is a review from Review Bot.
        Tool: PEP8 Style Checker
        Processed Files:
          djblets/webapi/responses.py
        Ignored Files:
      
      
    2. 
        
    reviewbot
    1. This is a review from Review Bot.
        Tool: Pyflakes
        Processed Files:
          djblets/webapi/responses.py
        Ignored Files:
      
      
    2. 
        
    chipx86
    1. Ship It!

    2. 
        
    KE
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-0.8.x (66ee7a6)
    chipx86
    1. Djblets 0.8.5 now contains this patch. Thanks!

    2.