Fix filtering SVN commits by branch in the New Review Request page.
Review Request #5987 — Created June 12, 2014 and submitted
The New Review Request page wasn't properly filtering commits by branch
for Subversion repositories. It was assuming it could start at a
revision and pass that to the equivalent ofsvn log. However, this
ended up picking up commits that existed on other branches as well.The Repository Commits API for commits now accepts a
branch=parameter,
which is the branch ID returned by the Repository Branches API. This is
passed through toget_commits(), which will then filter by that branch.Through this, it's possible to properly limit the commits shown to those
on the branch. We'll also be able to make use of this later for other
repositories, if they suffer the same problem.
Set up a repository with different commits on different branches, and
some shared history.Before this change, I was getting the wrong commits on different selected
branches.After, I was seeing only the commits I'd expect, which matched what 'svn log'
was showing for those branches.
| Description | From | Last Updated |
|---|---|---|
|
this.options.branch should be URL-encoded here. |
 david
|
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/webapi/resources/repository_commits.py reviewboard/scmtools/svn/pysvn.py reviewboard/webapi/resources/repository_branches.py Ignored Files: reviewboard/static/rb/js/resources/collections/repositoryCommitsCollection.js reviewboard/static/rb/js/newReviewRequest/views/postCommitView.js reviewboard/static/rb/js/resources/models/repositoryBranchModel.js reviewboard/static/rb/js/resources/models/repositoryModel.js
- Change Summary:
-
- Made a unit test more correct. It wasn't broken with this change, as the parameters were basically ignored, but now it's more consistent.
- URL-encoded both 'start' and 'branch'.
- Commit:
-
8830b98788ead3ea38897ef4430fcd8e9b35bde1583b1d0a4dfce18f80d7e48c3d276ef5d2a1912e
- Diff:
-
Revision 2 (+43 -12)
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/repository_commits.py reviewboard/scmtools/svn/pysvn.py reviewboard/webapi/resources/repository_branches.py Ignored Files: reviewboard/static/rb/js/newReviewRequest/views/tests/postCommitViewTests.js reviewboard/static/rb/js/resources/collections/repositoryCommitsCollection.js reviewboard/static/rb/js/newReviewRequest/views/postCommitView.js reviewboard/static/rb/js/resources/models/repositoryBranchModel.js reviewboard/static/rb/js/resources/models/repositoryModel.js
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: reviewboard/webapi/resources/repository_commits.py reviewboard/scmtools/svn/pysvn.py reviewboard/webapi/resources/repository_branches.py Ignored Files: reviewboard/static/rb/js/newReviewRequest/views/tests/postCommitViewTests.js reviewboard/static/rb/js/resources/collections/repositoryCommitsCollection.js reviewboard/static/rb/js/newReviewRequest/views/postCommitView.js reviewboard/static/rb/js/resources/models/repositoryBranchModel.js reviewboard/static/rb/js/resources/models/repositoryModel.js
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/repository_commits.py reviewboard/scmtools/svn/pysvn.py reviewboard/webapi/resources/repository_branches.py Ignored Files: reviewboard/static/rb/js/resources/collections/repositoryCommitsCollection.js reviewboard/static/rb/js/newReviewRequest/views/postCommitView.js reviewboard/static/rb/js/resources/models/repositoryBranchModel.js reviewboard/static/rb/js/resources/models/repositoryModel.js