Centralize get_branches() in the SVN backends.

Review Request #5980 — Created June 11, 2014 and submitted

Information

Review Board
release-2.0.x
fd0de4c...

Reviewers

The get_branches() logic was pretty complicated, and existed in two
places. This change pulls it into SVNTool, and adds new client backend
functions for performing the directory listing operations.

This also simplifies get_branches(), since it was doing a bunch of work
to build new dictionaries out of old ones, which shouldn't be necessary
anymore.

All unit tests pass for both backends.

reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/scmtools/svn/subvertpy.py
        reviewboard/scmtools/svn/pysvn.py
        reviewboard/scmtools/svn/__init__.py
        reviewboard/scmtools/svn/base.py
      Ignored Files:
    
    
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: Pyflakes
      Processed Files:
        reviewboard/scmtools/svn/subvertpy.py
        reviewboard/scmtools/svn/pysvn.py
        reviewboard/scmtools/svn/__init__.py
        reviewboard/scmtools/svn/base.py
      Ignored Files:
    
    
  2. 
      
david
  1. Ship It!

  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.0.x (c0500db)