Fix saving extension settings.
Review Request #5967 — Created June 10, 2014 and submitted — Latest diff uploaded
A recent change added a
request
parameter toSiteSettingsForm
, and
changed the calls in siteconfig to pass thedata
andfiles
values as keyword arguments.This broke the form, because extensions use the
configure_extension
view, which passes data as positional arguments.While that view could also just be updated for this, the convention is
to passdata
andfiles
as positional arguments, and most callers do
so. To provide the best compatibility, we now do this as well, and leave
optional keyword arguments (request
) as keyword arguments accessed
throughkwargs
.
Successfully saved extension settings.
Unit tests pass.