• 
      

    Fix saving extension settings.

    Review Request #5967 — Created June 10, 2014 and submitted

    Information

    Djblets
    release-0.8.x
    aabd620...

    Reviewers

    A recent change added a request parameter to SiteSettingsForm, and
    changed the calls in siteconfig to pass the data and files
    values as keyword arguments.

    This broke the form, because extensions use the configure_extension
    view, which passes data as positional arguments.

    While that view could also just be updated for this, the convention is
    to pass data and files as positional arguments, and most callers do
    so. To provide the best compatibility, we now do this as well, and leave
    optional keyword arguments (request) as keyword arguments accessed
    through kwargs.

    Successfully saved extension settings.

    Unit tests pass.

    Description From Last Updated

    local variable 'hook' is assigned to but never used

    reviewbotreviewbot

    local variable 'hook' is assigned to but never used

    reviewbotreviewbot
    reviewbot
    1. This is a review from Review Bot.
        Tool: PEP8 Style Checker
        Processed Files:
          djblets/siteconfig/views.py
          djblets/siteconfig/forms.py
          djblets/extensions/tests.py
        Ignored Files:
      
      
    2. 
        
    reviewbot
    1. This is a review from Review Bot.
        Tool: Pyflakes
        Processed Files:
          djblets/siteconfig/views.py
          djblets/siteconfig/forms.py
          djblets/extensions/tests.py
        Ignored Files:
      
      
    2. djblets/extensions/tests.py (Diff revision 1)
       
       
      Show all issues
       local variable 'hook' is assigned to but never used
      
    3. djblets/extensions/tests.py (Diff revision 1)
       
       
      Show all issues
       local variable 'hook' is assigned to but never used
      
    4. 
        
    david
    1. Ship It!

    2. 
        
    SM
    1. Ship It!

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-0.8.x (4636932)