• 
      

    Fix the reply draft banner sticking around after a second publish.

    Review Request #5964 — Created June 10, 2014 and submitted

    Information

    Review Board
    release-2.0.x
    33eba27...

    Reviewers

    Publishing a reply to a comment and then following it up with a second
    reply would result in the reply banner sticking around, acting as if the
    publish hadn't gone through.

    This happened because signal handlers for the "publishing" and
    "destroyed" events were registered twice on the first ReviewReply, which
    would cause the state to mess up. We only really needed to register
    these once.

    Posted a reply, published. Posted another, published. Both times, the banner
    disappeared.

    Also tested with discarding.

    Unit tests pass.

    reviewbot
    1. This is a review from Review Bot.
        Tool: PEP8 Style Checker
        Processed Files:
        Ignored Files:
          reviewboard/static/rb/js/views/tests/reviewBoxViewTests.js
          reviewboard/static/rb/js/views/reviewBoxView.js
      
      
    2. 
        
    reviewbot
    1. This is a review from Review Bot.
        Tool: Pyflakes
        Processed Files:
        Ignored Files:
          reviewboard/static/rb/js/views/tests/reviewBoxViewTests.js
          reviewboard/static/rb/js/views/reviewBoxView.js
      
      
    2. 
        
    david
    1. Ship It!

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (9a0085b)
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (9a0085b)