• 
      

    Added check to len of revision id on Mercurial

    Review Request #5941 — Created June 6, 2014 and discarded

    Information

    RBTools
    master
    538b6d8...

    Reviewers

    Calling rbt post with merge revision id as single parameter causing an error.
    I've added check to length of revision id.

    All tests complete.

    Description From Last Updated

    Col: 80 E501 line too long (132 > 79 characters)

    reviewbotreviewbot

    Col: 17 E129 visually indented line with same indent as next logical line

    reviewbotreviewbot

    Col: 80 E501 line too long (81 > 79 characters)

    reviewbotreviewbot
    reviewbot
    1. This is a review from Review Bot.
        Tool: PEP8 Style Checker
        Processed Files:
          rbtools/clients/mercurial.py
        Ignored Files:
      
      
    2. rbtools/clients/mercurial.py (Diff revision 1)
       
       
      Show all issues
      Col: 80
       E501 line too long (132 > 79 characters)
      
    3. 
        
    reviewbot
    1. This is a review from Review Bot.
        Tool: Pyflakes
        Processed Files:
          rbtools/clients/mercurial.py
        Ignored Files:
      
      
    2. 
        
    1T
    reviewbot
    1. This is a review from Review Bot.
        Tool: PEP8 Style Checker
        Processed Files:
          rbtools/commands/status.py
          rbtools/api/resource.py
          rbtools/utils/checks.py
          rbtools/commands/__init__.py
          rbtools/commands/diff.py
          rbtools/commands/patch.py
          rbtools/commands/post.py
          rbtools/clients/__init__.py
          rbtools/clients/mercurial.py
          rbtools/clients/git.py
          rbtools/clients/perforce.py
          rbtools/clients/svn.py
          rbtools/utils/users.py
        Ignored Files:
          docs/releasenotes/0.2-rc-1.rst
          docs/rbtools/rbt/commands/post.rst
          docs/releasenotes/0.5.7.rst
          docs/releasenotes/0.5.3.rst
          docs/rbtools/api/overview.rst
          docs/releasenotes/0.5.5.rst
          docs/releasenotes/0.5.6.rst
          docs/releasenotes/0.2.rst
          docs/releasenotes/0.5.rst
          docs/releasenotes/0.6.rst
      
      
    2. rbtools/clients/git.py (Diff revision 2)
       
       
      Show all issues
      Col: 17
       E129 visually indented line with same indent as next logical line
      
    3. rbtools/clients/mercurial.py (Diff revision 2)
       
       
      Show all issues
      Col: 80
       E501 line too long (81 > 79 characters)
      
    4. 
        
    1T
    Review request changed
    Status:
    Discarded
    reviewbot
    1. This is a review from Review Bot.
        Tool: Pyflakes
        Processed Files:
          rbtools/commands/status.py
          rbtools/api/resource.py
          rbtools/utils/checks.py
          rbtools/commands/__init__.py
          rbtools/commands/diff.py
          rbtools/commands/patch.py
          rbtools/commands/post.py
          rbtools/clients/__init__.py
          rbtools/clients/mercurial.py
          rbtools/clients/git.py
          rbtools/clients/perforce.py
          rbtools/clients/svn.py
          rbtools/utils/users.py
        Ignored Files:
          docs/releasenotes/0.2-rc-1.rst
          docs/rbtools/rbt/commands/post.rst
          docs/releasenotes/0.5.7.rst
          docs/releasenotes/0.5.3.rst
          docs/rbtools/api/overview.rst
          docs/releasenotes/0.5.5.rst
          docs/releasenotes/0.5.6.rst
          docs/releasenotes/0.2.rst
          docs/releasenotes/0.5.rst
          docs/releasenotes/0.6.rst
      
      
    2.