• 
      

    Modified checklist extension to use style.less

    Review Request #5932 — Created June 4, 2014 and submitted

    Information

    rb-extension-pack
    e9f3c15...

    Reviewers

    Modified the extension fo that it uses style.less instead of css file.

    Manual testing on Chrome and Firefox:

    • Added items to the list
    • Checked items off the checklist
    • Unchecked items on the checklist
    • Deleted items from the checklsit
    • Minimize the checklist
    • Maximize the checklist
    • Delete the whole checklist
    • Start a new checklist by refreshing the page
    reviewbot
    1. This is a review from Review Bot.
        Tool: PEP8 Style Checker
        Processed Files:
          checklist/checklist/extension.py
        Ignored Files:
      
      
    2. 
        
    reviewbot
    1. This is a review from Review Bot.
        Tool: Pyflakes
        Processed Files:
          checklist/checklist/extension.py
        Ignored Files:
      
      
    2. 
        
    david
    1. This should also delete the .css file.

      Can you detail the testing that you did?

    2. 
        
    SA
    mike_conley
    1. As David pointed out, you probably want to remove the old style.css file, and include a new style.less file along with this with anything that the old style.css file had in it.

    2. 
        
    SA
    david
    1. Ship It!

    2. 
        
    SA
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to dev/checklist-extension (eaed135)