• 
      

    Add HostingService.get_remote_repository.

    Review Request #5913 — Created May 31, 2014 and submitted

    Information

    Review Board
    master
    9306753...

    Reviewers

    This allows fetching of an individual repository, with the given ID. The
    IDs are specific to the HostingServices, and are provided when listing
    repositories.

    GitHub's remote repository IDs have been updated to provide both the
    owner and repository name as the ID, instead of the numeric ID. This is
    required in order to actually fetch repository information.

    Unit tests pass.

    Tested manually with the upcoming web API additions, with both valid and
    invalid repository IDs.

    Description From Last Updated

    Hmm. It might be nice to make _check_api_error preserve the code for HTTPErrors inside HostingServiceError so we can check against …

    daviddavid
    reviewbot
    1. This is a review from Review Bot.
        Tool: PEP8 Style Checker
        Processed Files:
          reviewboard/hostingsvcs/github.py
          reviewboard/hostingsvcs/tests.py
          reviewboard/hostingsvcs/service.py
        Ignored Files:
      
      
    2. 
        
    reviewbot
    1. This is a review from Review Bot.
        Tool: Pyflakes
        Processed Files:
          reviewboard/hostingsvcs/github.py
          reviewboard/hostingsvcs/tests.py
          reviewboard/hostingsvcs/service.py
        Ignored Files:
      
      
    2. 
        
    david
    1. 
        
    2. reviewboard/hostingsvcs/github.py (Diff revision 1)
       
       
      Show all issues

      Hmm. It might be nice to make _check_api_error preserve the code for HTTPErrors inside HostingServiceError so we can check against that instead.

    3. 
        
    chipx86
    reviewbot
    1. This is a review from Review Bot.
        Tool: PEP8 Style Checker
        Processed Files:
          reviewboard/hostingsvcs/errors.py
          reviewboard/hostingsvcs/tests.py
          reviewboard/hostingsvcs/github.py
          reviewboard/hostingsvcs/service.py
        Ignored Files:
      
      
    2. 
        
    reviewbot
    1. This is a review from Review Bot.
        Tool: Pyflakes
        Processed Files:
          reviewboard/hostingsvcs/errors.py
          reviewboard/hostingsvcs/tests.py
          reviewboard/hostingsvcs/github.py
          reviewboard/hostingsvcs/service.py
        Ignored Files:
      
      
    2. 
        
    david
    1. Ship It!

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (d29820d)