• 
      

    Add a profile field controlling whether users want to receive email. (1.7.x)

    Review Request #5908 — Created May 31, 2014 and submitted

    Information

    Review Board
    release-1.7.x
    ad14d03...

    Reviewers

    Not everyone wants to get emails from Review Board. This change adds a flag to
    the profile to control whether users will get anything directly addressed to
    them.

    This is the release-1.7.x version of the change. It differs from the 2.0.x
    version in that it doesn't include the unit test, and the profile forms code
    is different.

    • Ran unit tests.
    • Tested database evolution.
    • Tested the account settings.
    Description From Last Updated

    Col: 9 E129 visually indented line with same indent as next logical line

    reviewbotreviewbot

    Missing the trailing period.

    chipx86chipx86

    Trailing period.

    chipx86chipx86

    Col: 9 E129 visually indented line with same indent as next logical line

    reviewbotreviewbot

    Col: 9 E129 visually indented line with same indent as next logical line

    reviewbotreviewbot
    reviewbot
    1. This is a review from Review Bot.
        Tool: PEP8 Style Checker
        Processed Files:
          reviewboard/accounts/views.py
          reviewboard/accounts/evolutions/__init__.py
          reviewboard/accounts/evolutions/profile_send_email.py
          reviewboard/accounts/models.py
          reviewboard/notifications/email.py
          reviewboard/accounts/forms.py
        Ignored Files:
      
      
    2. reviewboard/notifications/email.py (Diff revision 1)
       
       
      Show all issues
      Col: 9
       E129 visually indented line with same indent as next logical line
      
    3. 
        
    reviewbot
    1. This is a review from Review Bot.
        Tool: Pyflakes
        Processed Files:
          reviewboard/accounts/views.py
          reviewboard/accounts/evolutions/__init__.py
          reviewboard/accounts/evolutions/profile_send_email.py
          reviewboard/accounts/models.py
          reviewboard/notifications/email.py
          reviewboard/accounts/forms.py
        Ignored Files:
      
      
    2. 
        
    david
    reviewbot
    1. This is a review from Review Bot.
        Tool: PEP8 Style Checker
        Processed Files:
          reviewboard/accounts/views.py
          reviewboard/accounts/evolutions/__init__.py
          reviewboard/accounts/models.py
          reviewboard/notifications/email.py
          reviewboard/accounts/evolutions/profile_should_send_email.py
          reviewboard/accounts/forms.py
        Ignored Files:
      
      
    2. reviewboard/notifications/email.py (Diff revision 2)
       
       
      Show all issues
      Col: 9
       E129 visually indented line with same indent as next logical line
      
    3. 
        
    reviewbot
    1. This is a review from Review Bot.
        Tool: Pyflakes
        Processed Files:
          reviewboard/accounts/views.py
          reviewboard/accounts/evolutions/__init__.py
          reviewboard/accounts/models.py
          reviewboard/notifications/email.py
          reviewboard/accounts/evolutions/profile_should_send_email.py
          reviewboard/accounts/forms.py
        Ignored Files:
      
      
    2. 
        
    chipx86
    1. 
        
    2. reviewboard/accounts/forms.py (Diff revision 2)
       
       
      Show all issues

      Missing the trailing period.

    3. reviewboard/accounts/models.py (Diff revision 2)
       
       
      Show all issues

      Trailing period.

    4. 
        
    david
    reviewbot
    1. This is a review from Review Bot.
        Tool: PEP8 Style Checker
        Processed Files:
          reviewboard/accounts/views.py
          reviewboard/accounts/evolutions/__init__.py
          reviewboard/accounts/models.py
          reviewboard/notifications/email.py
          reviewboard/accounts/evolutions/profile_should_send_email.py
          reviewboard/accounts/forms.py
        Ignored Files:
      
      
    2. reviewboard/notifications/email.py (Diff revision 3)
       
       
      Show all issues
      Col: 9
       E129 visually indented line with same indent as next logical line
      
    3. 
        
    reviewbot
    1. This is a review from Review Bot.
        Tool: Pyflakes
        Processed Files:
          reviewboard/accounts/views.py
          reviewboard/accounts/evolutions/__init__.py
          reviewboard/accounts/models.py
          reviewboard/notifications/email.py
          reviewboard/accounts/evolutions/profile_should_send_email.py
          reviewboard/accounts/forms.py
        Ignored Files:
      
      
    2. 
        
    chipx86
    1. Ship It!

    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-1.7.x (f8bc26f)