• 
      

    Use setuptools instead of distutils for extension packaging.

    Review Request #5876 — Created May 25, 2014 and submitted

    Information

    Djblets
    release-0.8.x
    99d7cf8...

    Reviewers

    The extension packaging code was using distutils's classes instead of
    setuptools's, which prevented more advanced features like MANIFEST.in
    rules from being used. A simple import change fixes this.

    Built packages with this, and saw that MANIFEST.in was being factored in.

    Description From Last Updated

    local variable 'full_path' is assigned to but never used

    reviewbotreviewbot
    reviewbot
    1. This is a review from Review Bot.
        Tool: PEP8 Style Checker
        Processed Files:
          djblets/extensions/packaging.py
        Ignored Files:
      
      
    2. 
        
    reviewbot
    1. This is a review from Review Bot.
        Tool: Pyflakes
        Processed Files:
          djblets/extensions/packaging.py
        Ignored Files:
      
      
    2. djblets/extensions/packaging.py (Diff revision 1)
       
       
      Show all issues
       local variable 'full_path' is assigned to but never used
      
    3. 
        
    david
    1. Ship It!

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-0.8.x (9589d29)