Fix handling of basedir in 'rbt patch'
Review Request #5855 — Created May 21, 2014 and submitted
Depending on the version of the Review Board server and the particular
repository type, the returned diffset object from the API may have no basedir,
may have a basedir of None, or may be a string. In the first two cases, we want
to normalize this to an empty string.This also handles a None repository base_path.
- Ran 'rbt patch'
- Ran unit tests.
-
This is a review from Review Bot. Tool: Pyflakes Processed Files: rbtools/commands/patch.py Ignored Files:
- Change Summary:
-
Add another, related bug fix.
- Description:
-
Depending on the version of the Review Board server and the particular
repository type, the returned diffset object from the API may have no basedir, may have a basedir of None, or may be a string. In the first two cases, we want to normalize this to an empty string. + + This also handles a None repository base_path.
- Bugs:
-
- Commit:
d605c04f3fe130871034513a6fbe261e2282e06b51e5f5f6b2e458811ed52655058e0d6c5127ddfe
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: rbtools/commands/patch.py rbtools/clients/__init__.py Ignored Files:
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: rbtools/commands/patch.py Ignored Files: