Summary

Fix our module import checks.

Review Request #5846 — Created May 20, 2014 and submitted May 20, 2014, 3:13 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

767463b...

Reviewers

Groups

reviewboard

People

Description

We have a number of checks to see if we can import certain modules. For

these, we use a combination of import statements and imp.find_module

calls. The reason is that some modules would fail to import on some

systems using imp.find_module.
The reason for that is that imp.find_module doesn't use registered

importers, and therefore can't find modules in zipped eggs. Furthermore,

our usage would cause leaked open file handles, since if the module is

represented by a .pyc file, imp.find_module would pre-import it.
Instead of dealing with all this, I've added a new, single function for

checking if modules can be imported. All checks in the codebase now use

this instead, giving us consistency and fixing the issues with zipped

eggs.

Testing Done

Unit tests pass.

The dev server could be run against Pillow, which wasn't working here before.

Hand-tested some of our modules that are more complex (like the S3 support in
django-storages), with and without the module.

Issues

Description	From	Last Updated
'striptags' imported but unused	reviewbot	May 20, 2014, 2:56 p.m.
'checks' imported but unused	reviewbot	May 20, 2014, 2:56 p.m.
While there are no strings in here (yet), this should still import unicode_literals.	david	May 20, 2014, 3:13 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/admin/checks.py
    reviewboard/manage.py
    reviewboard/admin/import_utils.py
    reviewboard/diffviewer/tests.py
    reviewboard/scmtools/forms.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/admin/checks.py
    reviewboard/manage.py
    reviewboard/admin/import_utils.py
    reviewboard/diffviewer/tests.py
    reviewboard/scmtools/forms.py
  Ignored Files:

reviewboard/manage.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'striptags' imported but unused
```
reviewboard/manage.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'checks' imported but unused
```

Change Summary:

Removed some unused imports.

Commit:

c6693c4143eac8ff57ba2c5c164e0eb811faa4e7

767463b293caffd3dab6a39a27b088e6aec39c33

Diff:

Revision 2 (+51 -69)

Show changes

	reviewboard/manage.py
	reviewboard/admin/checks.py
	reviewboard/admin/import_utils.py
	reviewboard/diffviewer/tests.py
	reviewboard/scmtools/forms.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/admin/checks.py
    reviewboard/manage.py
    reviewboard/admin/import_utils.py
    reviewboard/diffviewer/tests.py
    reviewboard/scmtools/forms.py
  Ignored Files:

This is a review from Review Bot.
  Tool: Pyflakes
  Processed Files:
    reviewboard/admin/checks.py
    reviewboard/manage.py
    reviewboard/admin/import_utils.py
    reviewboard/diffviewer/tests.py
    reviewboard/scmtools/forms.py
  Ignored Files:

Ship it!

reviewboard/admin/import_utils.py (Diff revision 2)
The issue has been resolved. Show all issues
```
While there are no strings in here (yet), this should still import unicode_literals.
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (8546c5f)

reviewboard/manage.py (Diff revision 1)

reviewboard/manage.py (Diff revision 1)