• 
      

    Update Review Bot to work with Review Board 2.0.

    Review Request #5806 — Created May 12, 2014 and submitted

    Information

    ReviewBot
    9119108...

    Reviewers

    Review Board had some changes that broke Review Bot in a few ways, some
    subtle.

    First, there are the usual updates for import locations. Django changed
    import locations for the urlpattern-related objects, which are now fixed
    here.

    Then there are more complicated fixes.

    Review Bot was unable to log in to Review Board with the provided
    session key. That's because Django now checks that the stored auth
    backend for a session is in our list of backends. ModelBackend isn't, so
    all logins failed. Instead of storing ModelBackend, we now store our
    StandardAuthBackend.

    After that, everything worked except for publishing. The API resource
    handling publishing of reviews was trying to use positional arguments
    when fetching an object, but it needed to use keyword arguments. In
    previous versions, positional arguments were apparently working, but
    this was never intended to be supported.

    There's also an update to use our new setup() function instead of the
    one that comes with setuptools.

    This, along with some changes made to Djblets and Review Board, make
    Review Bot functional again.

    Posted changes for review, and watched as Review Bot posted some reviews
    for the configured tools.

    SM
    1. Yay! don't forget to add yourself to the authors file :D

    2. extension/reviewbotext/extension.py (Diff revision 1)
       
       

      There was a reason I used the model backend in particular... I really can't remember though, and if this works, great!

    3. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (853777c)