Improve use of groups with the GitLab API.

Review Request #5792 — Created May 9, 2014 and submitted

Information

Review Board
master
bf21265...

Reviewers

The GitLab API is totally broken with pagination, but if users have a large
number of repositories which are separated into groups, we can do a better job.

This change is based on John Earl's code at /r/5789/ but I've made some
changes to keep things a bit more concise, added a separate error for when the
group name is incorrect, and added and fixed unit tests for everything.

  • The original change listed that the groups iteration code was tested against
    a large GitLab installation in both the devserver and production.
  • Ran unit tests.
JW
  1. Looks good to me, keeps spirit of the original and adds tests.

  2. 
      
JW
  1. On further inspection, did you miss the change to reviewboard/hostingsvcs/service.py in /r/5789, or has that gone in elsewhere? I thought needed that in order to successfully auth.

    1. I pushed that as a separate fix.

    2. great!

  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to master (2d9fc4c)