Summary

Include revision in View Diff summary head of files

Review Request #579 — Created Oct. 6, 2008 and discarded

Information

Owner

clach04

Repository

Review Board SVN (deprecated)

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Added revision id so that the file and rev is displayed at the top before the diffs. This is useful for _some_ SCMs that have integer per file version numbers. For some of the distributed SCM's this may not be so useful.

Raising review as a discussion point, see http://groups.google.com/group/reviewboard/browse_thread/thread/89a89ece9d5e1139

Testing Done

Tested with SVN and another SCM (that uses integers for rev id's) that is not officially supported by ReviewBoard

It looks like as-is, this will just format things in a system-agnostic way (<filename> <rev>). I wonder if there's a way to add some knowledge about the best way to format this, since each SCM has a "canonical" way of writing revision numbers.

For example:
SVN: <filename> r<rev>
Perforce: <filename>#<rev>
Git: <filename> <short-rev>...

clach04 Oct. 7, 2008, 3:21 a.m.

Nice idea, I guess we would need to sub-class core.Revision in each SCM implementation. Something along the lines of:

class SVNRevision(Revision):
    def __init__(self, name):
        self.name = name

    def __str__(self):
        ## NOTE, we should really use __unicode__
        return 'r%s' % self.name

    def __eq__(self, other):
        return self.name == str(other)

    def __ne__(self, other):
        return self.name != str(other)

    def __repr__(self):
        return '<Revision: %s>' % self.name


I'm still a rookie with the code base though, my guess is that this would require some changes where ever Revision is instantiated.

david Nov. 13, 2008, 2:49 p.m.

It would probably be less complex to just have a format_revision() function in the SCMTool for now.

chipx86 March 11, 2009, 7:22 p.m.
```
Any update on this?
```