Fish Trophy

chipx86 got a fish trophy!

Fish Trophy

Add the ability to remove source media files when building extensions.

Review Request #5775 — Created May 6, 2014 and submitted

Information

Djblets
master
862e3ad...

Reviewers

When packaging extensions, it's now possible to strip away all source
media files (non-minified JavaScript/CSS/LessCSS files) from the
resulting package. These are generally not needed, and doing so can
reduce the size of the package.

There's a remove-source-files option that can be set in setup.cfg that
will cause all JavaScript/CSS/LessCSS source files to be removed from
the build. This can be set by adding the following to setup.cfg:

[build_static_files]
remove_source_files = 1

Made use of this in an extension. With the setting set, I saw that the
package and build directory contained only the bundle files (stamped and
unstamped), and not the source files or minified source files.

Description From Last Updated

Should 'remove ...' start with a capital letter?

daviddavid

Can we rename build_dir in this method to something more specific, like media_build_dir? I initially panicked when reading this.

daviddavid

??

daviddavid
david
  1. 
      
  2. djblets/extensions/packaging.py (Diff revision 1)
     
     
    Show all issues

    Should 'remove ...' start with a capital letter?

    1. None of the built-in commands do that, so I was just going for consistency.

  3. djblets/extensions/packaging.py (Diff revision 1)
     
     
    Show all issues

    Can we rename build_dir in this method to something more specific, like media_build_dir? I initially panicked when reading this.

  4. 
      
chipx86
david
  1. 
      
  2. djblets/extensions/packaging.py (Diff revision 2)
     
     
     
     
    Show all issues

    ??

    1. Bah, those weren't supposed to get in there.

  3. 
      
chipx86
david
  1. Ship It!

  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to master (20cf8e2)