Fix context leaks in ActionHooks.
Review Request #5762 — Created May 2, 2014 and submitted — Latest diff uploaded
Context.update()
implies apush()
, but the ActionHooks weren't popping.
This meant that state would be leaked not only between hooks, but into
the main template as well.We now do a
pop()
after rendering the template.
Unit tests pass.
Diff Revision 2
This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.
orig
1
2
3
reviewboard/extensions/tests.py |
---|
reviewboard/extensions/templatetags/rb_extensions.py |
---|