• 
      

    Fix problems with "key=" lines in hgrc files.

    Review Request #5748 — Created April 28, 2014 and submitted

    Information

    RBTools
    master
    005b787...

    Reviewers

    The code that parses hgrc was assuming that all key=value lines had a non-empty
    value. This failed if the config included lines that didn't.

    Created an hgrc file with this configuration and ran rbtools commands. Saw that
    the bug reproduced before the change and didn't after.

    Description From Last Updated

    We can simplify this a bit: if len(line) == 2: key, value = line else: key = line[0] value = …

    chipx86chipx86
    chipx86
    1. 
        
    2. rbtools/clients/mercurial.py (Diff revision 1)
       
       
       
       
       
       
       
      Show all issues

      We can simplify this a bit:

      if len(line) == 2:
          key, value = line
      else:
          key = line[0]
          value = ''
      
      self.hgrc[key] = value.strip()
      
    3. 
        
    david
    chipx86
    1. Ship It!

    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (4ee1d19)