-
-
These should be rearranged a bit to follow the PEP-8 format of standard lib, third-party, this package. You can also catch ImportError without assigning it to a variable because you don't use the exception.
import logging from django import forms from django.utils.translation import ugettext_lazy as _ try: from jira.client import JRIA as JIRAClient from jira.exceptions import JIRAError has_jira = True except ImportError: has_jira = False from reviewboard.hostingsvcs.bugtracker import BugTracker ...
-
-
-
When logging things from within an exception handler, it's usually nice to add
exc_info=1
to thelogging.*()
parameters. -
-
-
-
Is it worth caching the result of this call anywhere? It seems likely that if you want one part of the issue data, you'll want the others.
Add support for JIRA bug tracker
Review Request #5745 — Created April 28, 2014 and discarded
Adds support for JIRA bug tracker.
Tested against a local JIRA instance and Atlassian demo JIRA at https://jira.atlassian.com/
Description | From | Last Updated |
---|---|---|
These should be rearranged a bit to follow the PEP-8 format of standard lib, third-party, this package. You can also … |
david | |
Indentation in here has an extra 4 spaces. |
david | |
This could use self._get_issue() |
david | |
When logging things from within an exception handler, it's usually nice to add exc_info=1 to the logging.*() parameters. |
david | |
This could use self._get_issue() |
david | |
Should add exc_info=1 |
david | |
Should add exc_info=1 |
david | |
Is it worth caching the result of this call anywhere? It seems likely that if you want one part of … |
david | |
You may want to also trim whitespace. |
david | |
Please add a docstring. |
david | |
Please add a blank line between these two. |
david | |
These could be combined into one statement. |
david | |
Please add a docstring. |
david | |
Please add a blank line between these two. |
david | |
These can be combined. |
david | |
Please add a docstring. |
david | |
Please add a blank line. |
david | |
These can be combined. |
david | |
Can you reformat this to put all the keys one indentation level down? issue = { 'description': ..., 'summary': ... … |
david | |
This should probably also include the URL of the JIRA server, in case there are multiple JIRA servers present. |
david | |
These could be combined into a single statement. |
david | |
If we get an exception, this will return None, which your other change will then just insert into the template. … |
david | |
Same question about None vs ''. |
david | |
Same question about None vs ''. |
david |
- Change Summary:
-
Fix issues
- Commit:
-
d32236486a7976eb8d1a22156541cc37372296ed502194adf821ee412c3b8d9b4219c72ad4d08b4c
- Change Summary:
-
Adapt to changes in r/5531
- Commit:
-
502194adf821ee412c3b8d9b4219c72ad4d08b4c79029782509ff9e7cf77a31c7c5e6fa1c51850cb
- Change Summary:
-
Add caching, adapt to changes in r/5531 and resolve JIRA url from repository
- Summary:
-
WIP: Add support for JIRA bug trackerAdd support for JIRA bug tracker
- Description:
-
Adds support for JIRA bug tracker.
- - TODO:
- Define how to get the bug tracker url on BugTracker - Commit:
-
79029782509ff9e7cf77a31c7c5e6fa1c51850cbf9df2984b7a1afbe8b366a559e8f18ba9a10c46b
- Change Summary:
-
Fix issues
- Commit:
-
f9df2984b7a1afbe8b366a559e8f18ba9a10c46b6f878b7c463406273e9e3f2bb3245f72fa3443db
- Change Summary:
-
Add requested docstrings
- Commit:
-
6f878b7c463406273e9e3f2bb3245f72fa3443dbc88beb43add74b9d3a59d2faee716bf96520fc53