• 
      

    Normalize filediff filenames during creation.

    Review Request #5734 — Created April 24, 2014 and submitted

    Information

    Review Board
    release-2.0.x
    6d2dc6f...

    Reviewers

    Some of the diff APIs that we're using for post-commit review request creation
    (looking at you, GitHub) give us filenames with leading slashes. This doesn't
    match what we have elsewhere, which makes things annoying if filenames don't
    match.

    Used this in conjunction with testing out the suggested reviewers feature. Saw
    that when I created a post-commit review request, the filenames matched what
    would have been created from rbtools.

    chipx86
    1. This looks fine, but shouldn't it be the responsibility of the GitHub HostingService code to return results in the expected format?

      1. I don't really want to add code to the GitHub HostingService to pre-process the diff that we get before passing it into the diff parser. I think we can also have this problem if people use their own tools to create the diff file(s).

    2. 
        
    chipx86
    1. Ship It!

    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (ed4044b)