Summary

Switch to fuzzy search in setup-repo to match repository path

Review Request #5724 — Created April 22, 2014 and submitted April 25, 2014, 1:34 p.m.

Information

Owner

1tush

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

Sometimes repository path on reviewboard server and on local copy of repository may contains slight difference (trailing slash, user credentials, etc.)

Now rbt setup-repo offers repository with closest path to local path.

Testing Done

Unit testing with nosetests
Ran 108 tests in 38.481s
OK (SKIP=24)

Some people do want their credentials in paths to match, so this will end up breaking some users out there.

It's probably also not the right place to do the match. This code shouldn't enforce lookup-related policies, and instead should use what it's given.

I think the right place for this is directly in rbt setup-repo. I could see setup-repo trying a couple variations (with and without credentials) for the lookups, but not rbt post or anything on the RB side. What we want to strongly encourage is using name-based lookups, and not path-based, since they're faster and less error-prone. rb setup-repo will set up a path-based repo, but could benefit from having this more fuzzy match to find the proper repo, if a direct match doesn't exist.

Change Summary:

Now i added fuzzy search in setup-repo.

Commit:

1cb8f1f377b4d201f14931f84bf83ec1872c1858

Diff:

Revision 2 (+15 -15)

Show changes

	rbtools/clients/__init__.py
	rbtools/commands/setup_repo.py

The code looks better, but can you update your change description to describe the new behavior?

Change Summary:: Change description due to new behavior
Summary:: Remove credentials from repository path
Switch to fuzzy search in setup-repo to match repository path
Description:: ~
If repository path saved with credentials (for example https://user@yourhost.com/user/repo.git) rtb commands like setup-repo, post, etc can't find repository on reviewboard server.
~ This changes clear this information from repository path.
~
Sometimes repository path on reviewboard server and on local copy of repository may contains slight difference (trailing slash, user credentials, etc.)
~
+
Now rbt setup-repo offers repository with closest path to local path.

I'm going to make some changes to make this more compatible with older (and newer) versions of python, then push it. Thanks!

Status:: Completed
Change Summary:: Pushed to release-0.6.x (8a0e94a)

~		If repository path saved with credentials (for example https://user@yourhost.com/user/repo.git) rtb commands like setup-repo, post, etc can't find repository on reviewboard server.
~		This changes clear this information from repository path.
	~	Sometimes repository path on reviewboard server and on local copy of repository may contains slight difference (trailing slash, user credentials, etc.)
	~
	+	Now rbt setup-repo offers repository with closest path to local path.