Honor INCLUDE_FILES when performing svn diff

 






 

 


  Review Request #5721
  —
  Created April 18, 2014 and discarded 

 


















 

  

   Information

  





 
 

  schmiddy
 









 
 

  RBTools
 









 
 

  
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  rbtools
 









 
 

  
 






 








 





  


 
 

  
Currently, the -I INCLUDE_FILES arguments are forgotten when performing rbt diff in an SVN repository, and the diff generated includes all modified files. Originally reported at: https://groups.google.com/d/msg/reviewboard/ATWLrhKXxSQ/9y-uCcJRSpEJ

 








  


 
 

  
Generated some local diffs, tested with directory and file arguments of varying number. Seems to work now the way it used to on 0.5.6, generating diffs including only the specified files.

 







 









 





  








 









 






  

 








 














 





 

  

   




david




   

   





  

 



 

  


   

   

    
 
david


    
   


  

  

  



    




  1. 
 
    
  
    
   
    I'm going to discard this in favor of a different fix. The real bug was that the diff_cmd.extend(files) line further down was indented four spaces too many.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   





 SC





   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  







  

   

    Status:
   

   


    Discarded