Summary

Sandboxing NavigationBarHook get_entries

Review Request #5708 — Created April 12, 2014 and submitted April 18, 2014, 3:35 p.m.

Information

Owner

edwinzg

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard, students

People

Description

Sandboxing NavigationBarHook get_entries

Added unit tests to test sandboxing

Testing Done

Unit testing, added to test suites in reviewboard/extensions/tests.py

Unit testing with and without the sandboxing

Issues

Description	From	Last Updated
You should remove the space at the end of this string. Otherwise, when they get concatenated, it will say "Error …	david	April 18, 2014, 12:42 a.m.

Diff:

Revision 2 (+14 -14)

Show changes

reviewboard/extensions/templatetags/rb_extensions.py

Diff:

Revision 3 (+34)

Show changes

	reviewboard/extensions/tests.py
	reviewboard/extensions/templatetags/rb_extensions.py

Summary:

[WIP] Sandboxing NavigationBarHook get_entries

Sandboxing NavigationBarHook get_entries

Description:

		Sandboxing NavigationBarHook get_entries
	+
	+	Added unit tests to test sandboxing

Testing Done:

	+	Unit testing, added to test suites in reviewboard/extensions/tests.py
	+
	+	Unit testing with and without the sandboxing

Diff:

Revision 4 (+43 -11)

Show changes

	reviewboard/extensions/tests.py
	reviewboard/extensions/templatetags/rb_extensions.py

reviewboard/extensions/templatetags/rb_extensions.py (Diff revision 4)

The issue has been resolved. Show all issues

You should remove the space at the end of this string. Otherwise, when they get concatenated, it will say "Error when running NavigationBarHook. get_entries function in extension..."

Diff:

Revision 5 (+43 -11)

Show changes

	reviewboard/extensions/tests.py
	reviewboard/extensions/templatetags/rb_extensions.py

Diff:

Revision 6 (+42 -11)

Show changes

	reviewboard/extensions/tests.py
	reviewboard/extensions/templatetags/rb_extensions.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (3da23cd)