Add some logging when check_install fails.

Review Request #5625 — Created March 14, 2014 and submitted

Information

RBTools
master
b9bef5b...

Reviewers

Right now, if the command-line tools aren't available in the path, rbtools will
just skip that backend silently. This change adds some debug logging that
indicates which backends are skipped due to missing dependencies.

Ran unit tests.

Description From Last Updated

This is actually a bit of a regression from where I think we want to go. is_supported was factored out …

chipx86chipx86
chipx86
  1. 
      
  2. rbtools/clients/perforce.py (Diff revision 1)
     
     
     
    Show all issues

    This is actually a bit of a regression from where I think we want to go.

    is_supported was factored out into P4Wrapper so that unit tests could override it, allowing for PerforceClient tests to run without needing Perforce.

    Can we keep is_supported and just add the logging statement?

    Down the road, I'd like to move toward more abstractions like P4Wrapper so that tests can be faster when they only care about processing known results.

  3. 
      
david
WJ
  1. Looks low risk & useful.

  2. 
      
chipx86
  1. Ship It!

  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to master (d66be16).