Move column initializers into __init__ calls.

Review Request #5538 — Created Feb. 23, 2014 and submitted

Information

Review Board
release-2.0.x
fa26d0d...

Reviewers

Several of the columns directly assigned member variables that ought to have
been included in __init__ instead. While this was perhaps slightly more
readable, it meant that the Column.__init__ method couldn't operate on them.

This change moves all those parameters into the __init__ calls. It also splits
the "To Me" column into using detailed_label_html and detailed_label, to
dovetail with my djblets change that fixes the sort order in the column
selector.

Looked at the column selector and saw that everything was in alphabetical
order, even when the column included HTML or other entities at the beginning of
the text.

Description From Last Updated

For readability, can we have one per line? Especially with labels and classes, it'd help (I care less about the …

chipx86chipx86
chipx86
  1. 
      
  2. reviewboard/datagrids/columns.py (Diff revision 1)
     
     
     
     
    Show all issues

    For readability, can we have one per line? Especially with labels and classes, it'd help (I care less about the booleans).

    Same below.

  3. 
      
david
chipx86
  1. Ship It!

  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.0.x (1d0c26b).