3258: POST /api/review-requests/<id>/diffs/ fails if the review request doesn't have a repository

david
david
david
Feb. 22, 2014
Traceback (most recent call last):

  File &quot;/usr/lib/python2.6/site-packages/Django-1.6.2-py2.6.egg/django/core/handlers/base.py&quot;, line 114, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)

  File &quot;/usr/lib/python2.6/site-packages/Django-1.6.2-py2.6.egg/django/views/decorators/cache.py&quot;, line 52, in _wrapped_view_func
    response = view_func(request, *args, **kwargs)

  File &quot;/usr/lib/python2.6/site-packages/Django-1.6.2-py2.6.egg/django/views/decorators/vary.py&quot;, line 19, in inner_func
    response = func(*args, **kwargs)

  File &quot;/usr/lib/python2.6/site-packages/Djblets-0.8alpha3-py2.6.egg/djblets/webapi/resources.py&quot;, line 445, in __call__
    result = view(request, api_format=api_format, *args, **kwargs)

  File &quot;/usr/lib/python2.6/site-packages/Djblets-0.8alpha3-py2.6.egg/djblets/webapi/resources.py&quot;, line 663, in post
    return self.create(*args, **kwargs)

  File &quot;/usr/lib/python2.6/site-packages/Djblets-0.8alpha3-py2.6.egg/djblets/webapi/decorators.py&quot;, line 115, in _call
    return view_func(*args, **kwargs)

  File &quot;/usr/lib/python2.6/site-packages/Djblets-0.8alpha3-py2.6.egg/djblets/webapi/decorators.py&quot;, line 136, in _checklogin
    return view_func(*args, **kwargs)

  File &quot;/usr/lib/python2.6/site-packages/Djblets-0.8alpha3-py2.6.egg/djblets/webapi/decorators.py&quot;, line 115, in _call
    return view_func(*args, **kwargs)

  File &quot;/usr/lib/python2.6/site-packages/ReviewBoard-2.0beta3-py2.6.egg/reviewboard/webapi/decorators.py&quot;, line 110, in _check
    return view_func(*args, **kwargs)

  File &quot;/usr/lib/python2.6/site-packages/Djblets-0.8alpha3-py2.6.egg/djblets/webapi/decorators.py&quot;, line 115, in _call
    return view_func(*args, **kwargs)

  File &quot;/usr/lib/python2.6/site-packages/Djblets-0.8alpha3-py2.6.egg/djblets/webapi/decorators.py&quot;, line 115, in _call
    return view_func(*args, **kwargs)

  File &quot;/usr/lib/python2.6/site-packages/Djblets-0.8alpha3-py2.6.egg/djblets/webapi/decorators.py&quot;, line 285, in _validate
    return view_func(*args, **new_kwargs)

  File &quot;/usr/lib/python2.6/site-packages/ReviewBoard-2.0beta3-py2.6.egg/reviewboard/webapi/resources/diff.py&quot;, line 272, in create
    request=request)

  File &quot;/usr/lib/python2.6/site-packages/ReviewBoard-2.0beta3-py2.6.egg/reviewboard/reviews/forms.py&quot;, line 95, in __init__
    data, *args, **kwargs)

  File &quot;/usr/lib/python2.6/site-packages/ReviewBoard-2.0beta3-py2.6.egg/reviewboard/diffviewer/forms.py&quot;, line 41, in __init__
    if self.repository.get_scmtool().get_diffs_use_absolute_paths():

AttributeError: 'NoneType' object has no attribute 'get_scmtool'
david
#1 david
Fixed in release-2.0.x (25fae79).
  • +Fixed