-
-
-
rbt post help output
64 (bzr/git/hg/hgsubversion only)
We can probably remove "hgsubversion" from this list (or we should add git-svn and git-p4).
-
rbt post help output
128 --basedir=PATH the absolute path in the repository the diff was
129 generated in. Will override the detected path.
This should maybe also mention that it's useful with --diff-filename.
-
rbt post help output
111 Tracking branch from which your branch is derived
Can we go through and make all the argument descriptions start with a capital letter like this one does? I think it looks nice, and it makes it way less weird for descriptions that have multiple sentences.
(Perods wouldn't hurt, too).
-
-
rbt post help output
54 new diff (only available if your repository supports
55 changesets)
Can we change this to say Perforce/Plastic specifically? SVN and ClearCase support "changesets" but it's different.
-
rbt post help output
56 --diff-only uploads a new diff, but does not update info from the
57 changelist.
This should also be Perforce/Plastic specific. Perhaps we can even move these down into an SCM-specific section?
-
rbt post help output
133 generate the diff for review based on a local SVN
134 changelist
This should say that this argument is deprecated.
Organize the rbt post --help output.
Review Request #5463 — Created Feb. 12, 2014 and submitted
rbt post has a lot of options, and it was hard to figure out which
options were intended to serve which purposes, unless you knew what you
were looking for.This organizes all the options into groups. To do this, I've implemented
a custom OptionGroup class that just wraps optparse's OptionGroup.
Commands can use this to group instances of our Option class under a
name and optional description.The options are divided into the following groups:
* Posting Options
* Review Board Server Options
* Repository Options
* Review Request Field Options
* Diff Generation Options
* Git Options
* Perforce Options
* Subversion Options
Checked the help output and saw all the nice new groups.
| Description | From | Last Updated |
|---|---|---|
|
Can we move this to be the first group listed? |
 david
|
|
|
We can probably remove "hgsubversion" from this list (or we should add git-svn and git-p4). |
david
|
|
|
This should maybe also mention that it's useful with --diff-filename. |
david
|
|
|
Can we go through and make all the argument descriptions start with a capital letter like this one does? I … |
david
|
|
|
specifiesthe |
david
|
|
|
Can we change this to say Perforce/Plastic specifically? SVN and ClearCase support "changesets" but it's different. |
david
|
|
|
This should also be Perforce/Plastic specific. Perhaps we can even move these down into an SCM-specific section? |
david
|
|
|
This should say that this argument is deprecated. |
david
|
- Change Summary:
-
- Moved "Posting Options" to the top.
- Reworded many of the descriptions. They're all proper sentences now, and much of the wording has improved.
- Made it more clear what options applied to what types of repositories.
- Marked up all deprecated options in a consistent way.
- Description:
-
rbt post has a lot of options, and it was hard to figure out which
options were intended to serve which purposes, unless you knew what you were looking for. This organizes all the options into groups. To do this, I've implemented
a custom OptionGroup class that just wraps optparse's OptionGroup. Commands can use this to group instances of our Option class under a name and optional description. The options are divided into the following groups:
~ - Review Board Server Options
~ - Repository Options
~ - Posting Options
~ - Review Request Field Options
~ - Diff Generation Options
~ - Git Options
~ - Perforce Options
~ - Subversion Options
~ * Posting Options
~ * Review Board Server Options ~ * Repository Options ~ * Review Request Field Options ~ * Diff Generation Options ~ * Git Options ~ * Perforce Options ~ * Subversion Options - Commit:
-
8b029655d83d63004f287eeeebac0a5d3071ca34adf58fe2def30c9f6b1520ae5e465b4750d26934
- Diff:
-
Revision 2 (+350 -239)
- Removed Files:
- Added Files: