- Change Summary:
-
Added a blank line between the URL lines.
- Description:
-
+ Improve the resulting URL output from rbt post.
+ The new change to display the diff URL was a nice addition, but
displaying both URLs staggered on consecutive lines felt a little hard to read. This aligns the URLs to help with the readability. It also adds a blank
~ line after, which helps separate the results from the prompt (something ~ that's bothered me for a while). ~ line between and after, which helps separate the results from each other ~ and the prompt (something that's bothered me for a while). This makes it + easier to click the links without clicking the wrong thing. - Testing Done:
-
Posted this diff and saw:
Review request #5458 posted.Review request: https://reviews.reviewboard.org/r/5458/
+ Diff: https://reviews.reviewboard.org/r/5458/diff/
- Commit:
-
e9818ba2c1442aa65b05455129b650762ee2362aec556cb08bae5f141c1426e9ed79edf914421f03
- Diff:
-
Revision 2 (+3 -1)
Improve the resulting URL output from rbt post.
Review Request #5458 — Created Feb. 11, 2014 and submitted
Improve the resulting URL output from rbt post.
The new change to display the diff URL was a nice addition, but
displaying both URLs staggered on consecutive lines felt a little hard
to read.This aligns the URLs to help with the readability. It also adds a blank
line between and after, which helps separate the results from each other
and the prompt (something that's bothered me for a while). This makes it
easier to click the links without clicking the wrong thing.
Posted this diff and saw:
Review request #5458 posted. Review request: https://reviews.reviewboard.org/r/5458/ Diff: https://reviews.reviewboard.org/r/5458/diff/
| Description | From | Last Updated |
|---|---|---|
|
I think it's really weird to right-align the "Diff" text. How about: Review Request: ... Diff: ... ? |
 david
|
- Change Summary:
-
Left-align the text.
- Commit:
-
ec556cb08bae5f141c1426e9ed79edf914421f03963de064c5f8569570ee62a219a5d239cba2fed0
- Diff:
-
Revision 3 (+3 -1)