- Testing Done:
-
Posted using the following scenarios using Git and Mercurial:
rbt post
rbt post HEAD
~ rbt post <sha1>
~ rbt post <sha1> <sha2>
~ rbt post sha1
~ rbt post sha1 sha2
In the first three, the proper commit ID was attached to the review request.
In the fourth with the revision range, the commit ID was unset on the review request.
Provide Git and Mercurial commit IDs when posting diffs.
Review Request #5446 — Created Feb. 9, 2014 and submitted
Review Board 2.0 supports associating commit IDs with review requests,
but it must be provided by the client.RBTools now provides these commit IDs, when returned by the diff call.
These are only provided by Git and Mercurial right now, where they're
more useful and in higher demand.The commit ID won't be posted if running on older versions of
Review Board.
Posted using the following scenarios using Git and Mercurial:
rbt postrbt post HEADrbt post sha1rbt post sha1 sha2
In the first three, the proper commit ID was attached to the review request.
In the fourth with the revision range, the commit ID was unset on the review request.
