Summary

Don't auto-collapse review boxes that have open issues or drafts.

Review Request #5411 — Created Feb. 6, 2014 and submitted Feb. 6, 2014, 5:49 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Don't auto-collapse review boxes that have open issues or drafts.

It was easy to lose open issues after posting a change, since the boxes
would collapse. It was also annoying to have to reopen old reviews that
you were still commenting on (though at least the draft banner was
visible).

We now remove the collapsed state on boxes if they have any open issues
listed (and the viewing user is the author of the review request),
or if there's any draft reviews, making it easier to see the reviews
that still need attention.

Testing Done

Tested with a review request that had some draft replies, reviews with
some open issues, reviews with all closed issues, and reviews without
any issues.

The boxes were expanded only for the reviews added after the latest
change description and for drafts or ones with open issues.

I'm cool with not auto-collapsing reviews with draft replies, but I'm not so sure about reviews with open issues. Maybe only for the submitter?

chipx86 Feb. 6, 2014, 2:44 p.m.

I suppose we could do that. I think as a reviewer, though, I'd want to see what issues are still open for discussion before making the same comments.

david Feb. 6, 2014, 2:45 p.m.

Well, as a reviewer you'll always see them at least once, and we have the summary table to see what's still open.

Change Summary:

Only uncollapse reviews with issues when the viewing user is the owner of the review request.

Diff:

Revision 2 (+13)

Show changes

reviewboard/reviews/views.py

Ship it!

Looks good. Can you update your change description to explain the submitter behavior?

Description:: Don't auto-collapse review boxes that have open issues or drafts.

It was easy to lose open issues after posting a change, since the boxes
would collapse. It was also annoying to have to reopen old reviews that
you were still commenting on (though at least the draft banner was
visible).

We now remove the collapsed state on boxes if they have any open issues
~ listed or if there's any draft reviews, making it easier to see the
~ reviews that still need attention.
~ listed (and the viewing user is the author of the review request),
~ or if there's any draft reviews, making it easier to see the reviews
+ that still need attention.

Status:: Completed

		Don't auto-collapse review boxes that have open issues or drafts.

		It was easy to lose open issues after posting a change, since the boxes
		would collapse. It was also annoying to have to reopen old reviews that
		you were still commenting on (though at least the draft banner was
		visible).

		We now remove the collapsed state on boxes if they have any open issues
~		listed or if there's any draft reviews, making it easier to see the
~		reviews that still need attention.
	~	listed (and the viewing user is the author of the review request),
	~	or if there's any draft reviews, making it easier to see the reviews
	+	that still need attention.