Summary

Issue 3189: Add a link to the interdiff from the review request draft banner

Review Request #5384 — Created Feb. 1, 2014 and submitted Feb. 2, 2014, 9:11 p.m.

Information

Owner

tomiaijo

Repository

Review Board

Branch

master

Bugs

3189

Depends On

Reviewers

Groups

reviewboard

People

Description

Adds a link to the interdiff from the review request draft banner to make it easier to see the change the draft contains.

Fixes https://code.google.com/p/reviewboard/issues/detail?id=3189.

Testing Done

Tested the change using a development review board with different drafts (with and without diffsets).

Unit tests pass.

Files

Issues

Description	From	Last Updated
We probably want to clarify that this is about the diff. How about we move this below the <input> tags, …	david	Feb. 2, 2014, 10:31 a.m.

david Feb. 2, 2014, 12:22 a.m.

Please add the bug number into the "Bugs" field, as well.

reviewboard/templates/reviews/review_header.html (Diff revision 1)

The issue has been resolved. Show all issues

We probably want to clarify that this is about the diff. How about we move this below the <input> tags, and do something like this:

<p>{% trans "This draft adds a new diff." %} <a ...>{% trans "Show changes" %}</a>.</p>

Bugs:

3189

Diff:

Revision 2 (+3)

Show changes

reviewboard/templates/reviews/review_header.html

Added Files:

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (8e710c6). Thanks!