Issue 3201: Put a link next to rich-text fields.
Review Request #5378 — Created Feb. 1, 2014 and submitted
Appended the markdown link next to the buttons in 'Description', 'Testing Done', 'Comments' and 'Reply to comments' fields.
For each view, checked the state of all combinations of buttons pressed/unpressed to make sure the markdown link appears when beginning edit and disappears when cancelling edit. For reviewReply and reviewRequest views, opened multiple text editors at the same time to check if the markdown informaiton appears.
Description | From | Last Updated |
---|---|---|
Can you use CSS to right-align this within its parent? I think I'd also like it if it said something … |
david | |
Leave this blank line here. |
david | |
Instead of using to split this across lines, I think I'd prefer joining an array of strings: $('.body-top').append([ '<a class="markdown-info" … |
david | |
Same here with string joins. |
david | |
This line has trailing whitespace. |
david | |
Please put a space between if and (. |
david | |
Same here with string joins. |
david | |
Please put a space between if and (. |
david | |
Please put a space between if and (. |
david | |
This should be indented two spaces, and have a space between the : and the value. |
david | |
Leave this line here. |
david | |
These look like they're indented 3 spaces instead of 4. |
david | |
The strings should be indented 4 spaces in from the previous alignment. It might be worth moving all the chained … |
david | |
Same here with indentation and spaces at the ends of each string. |
david |
-
This is looking better.
I didn't see code or screenshots for doing this to the comment dialog. Can you also show a screenshot of the review dialog with multiple comments in the draft?
-
Can you use CSS to right-align this within its parent?
I think I'd also like it if it said something like "This field uses Markdown" instead of just "Markdown Field".
-
Instead of using to split this across lines, I think I'd prefer joining an array of strings:
$('.body-top').append([ '<a class="markdown-info" ', ' href="..." ', ' target="_blank">...</a>' ].join(''));
-
-
-
- Bugs:
-
-
-
-
-
The strings should be indented 4 spaces in from the previous alignment.
It might be worth moving all the chained methods down and indent them only 4 spaces. Something like this:
$draftComment .find('pre.reviewtext') .inlineEditor('buttons') .append([ '<a class="markdown-info" ' ... ]);
You also need to add spaces at the ends of these strings, because the join won't insert them. As it is, this would create the string "<a class="markdown-info"href="..."target="...">"
-
- Change Summary:
-
Made the requested indentation changes
- Testing Done:
-
+ For each view, checked the state of all combinations of buttons pressed/unpressed to make sure the markdown link appears when beginning edit and disappears when cancelling edit. For reviewReply and reviewRequest views, opened multiple text editors at the same time to check if the markdown informaiton appears.
- Diff:
-
Revision 4 (+1916 -1875)