Rewrite the My Account page.

Review Request #5315 — Created Jan. 24, 2014 and submitted

Information

Review Board
master

Reviewers

Rewrite the My Account page.

This is an extensive rewrite of the page that provides better
organization and extensibility, based on the equivalent page in
RBCommons.

The new page provides a navbar on the side for navigating the various
account preference "pages," which are shown in the main content area.
Each "page" can show one or more forms for changing preferences.

The biggest change in content is the Groups page. Instead of a terrible
flat list of checkboxes, we now display every group in a clean list,
with buttons for dynamically joining or leaving the group. The group is
also filterable, making it easy to find a group you want.

The whole infrastructure is designed to be extensible. While the hooks
aren't there yet, everything below them are. Pages can be registered or
unregistered, and the forms on a page can also be registered or
unregistered. This will later let extensions provide their own
preferences for each user.

Tested all preferences.

Tested joining and leaving groups.

Tested filtering groups.

Tested custom pages and forms on existing pages.


Description From Last Updated

I think these should be "settings". After that, this page can maybe be renamed to "Account Information" or somesuch.

daviddavid

Localization?

daviddavid

Localization

daviddavid

AuthenticationPage should only be available when using builtin auth, no?

daviddavid
david
  1. 
      
  2. Show all issues

    I think these should be "settings". After that, this page can maybe be renamed to "Account Information" or somesuch.

    1. I was basically mirroring RBCommons. I can move these.

      I felt these were more appropriate under "Profile," but if this is renamed to "Account Information," then that move makes a lot of sense.

    2. Hmm actually.. I went to make the change, and I'm just not sure. "Keep your user profile private" feels like it should be tied to your profile, and not settings. I see settings as controlling the behavior of your experience with Review Board. I think Time Zone is also more profile-related and not so much a setting in that way.

      I kind of like how it is today honestly.

    3. Time zone is how you interact with Review Board and completely unrelated to who you are or whether you want others to know who you are.

    4. Okay. I can go both ways on this. Making some changes to try to refine this.

    5. See if that looks any better.

  3. reviewboard/accounts/forms/account.py (Diff revision 1)
     
     
    Show all issues

    Localization?

  4. reviewboard/accounts/forms/account.py (Diff revision 1)
     
     
    Show all issues

    Localization

  5. reviewboard/accounts/pages.py (Diff revision 1)
     
     
    Show all issues

    AuthenticationPage should only be available when using builtin auth, no?

    1. I plan to add some forms to that page. We'll still want it regardless.

      If using an auth backend that doesn't allow changing the password, then the form will be marked as invisible. The page itself will only show up in the sidebar if it has at least one visible form. If an extension then added a form to this page, the page would show up, displaying only that form.

  6. 
      
chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed