-
-
This is going to cause all kinds of problems for upgrades, according to the docs. We'd also have to document how to install it and all prereqs, since a lot of our supported installs are less likely to package Pillow.
Since PIL support is going away in 1.8, and is compatible until then, let's change this to allow for both. This will give people time to move away from PIL without breaking people.
We should also then emit a deprecation warning in rb-site, and add some docs.
Googling around shows that this pattern is common: https://github.com/mapproxy/mapproxy/blob/master/setup.py
I'd suggest we inverse that, though we'd probably have to do it with import testing, given that PIL isn't very setuptools-friendly. So, require PIL if it's there and Pillow is not, and otherwise require Pillow.
Bump djblets django dependency to 1.6
Review Request #5309 — Created Jan. 23, 2014 and submitted
Bump djblets django dependency to 1.6
This is relatively straightforward. The changes here include: * Bumping django to >= 1.6.1 * Replacing PIL with Pillow as the preferred image library. Existing PIL
installations will continue to work. * Remove obsolete call tosetup_environ()in build-media.py * Fix call tocompile_messages()in build-i18n.py * Changing some tests in the datagrid to account for the fact that 'timesince'
now uses non-breaking spaces between the number and the unit.
- Ran unit tests.
- Installed djblets and saw that it used PIL if installed, and preferred Pillow
if not.
| Description | From | Last Updated |
|---|---|---|
|
This is going to cause all kinds of problems for upgrades, according to the docs. We'd also have to document … |
 chipx86
|
|
|
I don't think this is guaranteed to work, due to how PIL is packaged in some cases, hence the import … |
chipx86
|
|
|
Can we keep this inline, and just use a variable for the PIL vs. Pillow dependency? |
chipx86
|
- Change Summary:
-
- Update PIL vs. Pillow to be more forgiving.
- Make changes to build-* helpers.
- Description:
-
Bump djblets django dependency to 1.6
This is relatively straightforward. The changes here include:
* Bumping django to >= 1.6.1 ~ * Replacing PIL with Pillow ~ * Replacing PIL with Pillow as the preferred image library. Existing PIL + installations will continue to work. + * Remove obsolete call to setup_environ()in build-media.py+ * Fix call to compile_messages()in build-i18n.py* Changing some tests in the datagrid to account for the fact that 'timesince' now uses non-breaking spaces between the number and the unit. - Testing Done:
-
~ Ran unit tests.
~ - Ran unit tests.
+ - Installed djblets and saw that it used PIL if installed, and preferred Pillow
if not.