Summary

Make "Auto-Submitted: auto-generated" header optional with a settings flag

Review Request #5276 — Created Jan. 17, 2014 and submitted Jan. 22, 2014, 1:30 p.m.

Information

Owner

anselina

Repository

Review Board

Branch

master

Bugs

2646

Depends On

Reviewers

Groups

reviewboard, students

People

Description

Some mailing lists filter out emails containing the "Auto-Submitted: auto-generated" header. Making this header optional allows those who use such mailing lists to receive Review Board emails.

Testing Done


Manually enabled and disabled the header settings flag in E-Mail Settings.
Ran unit tests.

Issues

Description	From	Last Updated
Maybe add some help text to describe why you would want to turn this on/off?	chipx86	Jan. 21, 2014, 7:26 p.m.

This looks great! All the code is fine and in the right place. I just have one suggestion to help those unfamiliar with the header.

reviewboard/admin/forms.py (Diff revision 1)

The issue has been resolved. Show all issues

Maybe add some help text to describe why you would want to turn this on/off?

Change Summary:

Added help text to describe when someone would want to enable/disable this header, as suggested.

Diff:

Revision 2 (+14 -3)

Show changes

	reviewboard/admin/forms.py
	reviewboard/admin/siteconfig.py
	reviewboard/notifications/email.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (4a8c12c). Thanks!