• 
      

    Finish tranisition for new revisions syntax.

    Review Request #5264 — Created Jan. 15, 2014 and submitted

    Information

    RBTools
    master

    Reviewers

    Finish tranisition for new revisions syntax.

    This change does a handful of things:
    * Updates the ClearCase implementation to use the new diff method, and changes
    it from using --tracking-branch to a brtype: prefix.
    * Fixes up ClearCase documentation for the new syntax.
    * Cleans up the get_diff method, now that there are no legacy consumers.
    * Changes the --revision-range argument to just print an error.
    * Changes the help for the options to say [revisions] instead of
    [changenum].
    * Updates the docs to remove --revision-range
    * Updates the docs to list -I/--include

    • Ran unit tests.
    • Built docs and verified that they looked right.
    Description From Last Updated

    Can we list the supported SCMs?

    chipx86chipx86

    Why is this section gone? Seems like it's still useful.

    chipx86chipx86

    Can you change "reviewboard" to "Review Board?"

    chipx86chipx86

    Can we also list the SCMs we support here? I know it's possible these can get out of sync, but …

    chipx86chipx86

    Is this still needed?

    chipx86chipx86

    Can we call _do_diff once at the end? Also, might be worth having an else: that at least asserts so …

    chipx86chipx86
    chipx86
    1. 
        
    2. docs/rbtools/rbt/commands/diff.txt (Diff revision 1)
       
       
       
      Show all issues

      Can we list the supported SCMs?

    3. docs/rbtools/rbt/commands/post.txt (Diff revision 1)
       
       
       
       
       
      Show all issues

      Why is this section gone? Seems like it's still useful.

      1. There were two copies of this section in the page. I removed one of them.

      2. Ah cool, didn't notice.

    4. docs/rbtools/rbt/commands/post.txt (Diff revision 1)
       
       
      Show all issues

      Can you change "reviewboard" to "Review Board?"

    5. docs/rbtools/rbt/commands/post.txt (Diff revision 1)
       
       
       
      Show all issues

      Can we also list the SCMs we support here?

      I know it's possible these can get out of sync, but at least it gives a starting point for users.

    6. rbtools/clients/clearcase.py (Diff revision 1)
       
       
      Show all issues

      Is this still needed?

    7. rbtools/clients/clearcase.py (Diff revision 1)
       
       
       
       
       
       
       
       
       
       
      Show all issues

      Can we call _do_diff once at the end?

      Also, might be worth having an else: that at least asserts so we don't return None if something weird changes later.

      1. I'd rather leave the _do_diff where it is, because as I integrate the patches for labels and UCM activities, not everything will call it directly.

      2. That's fair.

    8. 
        
    david
    chipx86
    1. Ship It!
    2. 
        
    david
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (28c1ac5).