921: Add post-commit review submission to post-review for perforce

dbo****@gmai***** (Google Code) (Is this you? Claim this profile.)
david
david
Jan. 7, 2014
1747, 2509
What's the URL of the page containing the problem?
https://reviewboard.eng.vmware.com/r/64330/

What steps will reproduce the problem?
1. Create and submit a change.
2. post-review the change
3. Try to view the diff on reviewboard

What is the expected output? What do you see instead?
I created a quick fix and submitted it.  Tried to send out a posthumous
review, and got an error telling me the change was not pending.  I went to
my outgoing reviews to send out a different review, and noticed that the
review for the already-submitted change existed after all.  I sent it out,
and tried to view the diff, only to discover there was no diff.

Ideally, post-review should probably verify that the change is pending
before creating a review in the database.


What operating system are you using? What browser?


Please provide any additional information below.
david
#1 david
  • +Component-RBTools
david
#2 david
  • -Type-Defect
    +Type-Enhancement
  • +Add post-commit review submission to post-review for perforce
david
#5 david
  • +PendingReview
  • +david
david
#6 david
This is now implemented in rbtools master (9ba6c27). When we release rbtools 0.6, it'll be available in a release.

The syntax will be one of these:

rbt post CLN
rbt post CLN1 CLN2

to post either a single submitted changelist or a range of changes between two submitted changelists. You can't mix submitted changelists and pending/shelved.
  • -PendingReview
    +Fixed