• 
      

    Make check_options raise an error instead of exiting.

    Review Request #5112 — Created Dec. 13, 2013 and submitted

    Information

    RBTools
    master

    Reviewers

    Make check_options raise an error instead of exiting.

    The SCMClient.check_options method as written would print an error message to
    stderr and called sys.exit(). This is kind of a crummy design, which meant that
    running our test suite would have some errors printed in the middle of the
    suite output.

    I've changed this to raise an exception instead, and replicated the print/exit
    behavior in the two non-test places that call it.

    Ran unit tests.

    Description From Last Updated

    Mind adding a docstring?

    chipx86chipx86

    Can you put a blank line between these? These are separate logical blocks of code. Also, need to add a …

    chipx86chipx86

    We should ad a newline.

    chipx86chipx86
    chipx86
    1. 
        
    2. rbtools/clients/errors.py (Diff revision 1)
       
       
      Show all issues

      Mind adding a docstring?

    3. rbtools/commands/__init__.py (Diff revision 1)
       
       
       
      Show all issues

      Can you put a blank line between these? These are separate logical blocks of code.

      Also, need to add a newline in the output here too.

    4. rbtools/postreview.py (Diff revision 1)
       
       
      Show all issues

      We should ad a newline.

    5. 
        
    david
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (74ebdf0).